Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Batch Pool] Fix issue when setting multiple env var in pool start task #2685

Merged
merged 1 commit into from
Jan 17, 2019

Conversation

jcorioland
Copy link
Contributor

This PR fixes #2673.
Was just a value capture issue inside a for loop.
I've added unit test to reproduce the issue and committed a fix.

@ghost ghost added the size/XS label Jan 16, 2019
@katbyte katbyte added this to the 2.0.0 milestone Jan 17, 2019
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @jcorioland! LGTM 👍

katbyte added a commit that referenced this pull request Jan 17, 2019
@katbyte katbyte merged commit 3b32b8b into hashicorp:master Jan 17, 2019
@tombuildsstuff tombuildsstuff modified the milestones: 2.0.0, 1.22.0 Jan 21, 2019
@ghost
Copy link

ghost commented Mar 5, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to set multiple environment settings in start task for batch pool
3 participants