Add Connection Monitor resource and Network Watcher data source

[lewinski]

This PR adds a new resource to manage Connection Monitors, which allow network connectivity monitoring between VMs and an endpoint (another VM, IP, or FQDN) via the existing Network Watcher resources.

Because Network Watchers are limited to one per region per subscription, this PR also adds a Network Watcher data source. This may be useful when multiple Terraform configurations using Network Watchers, Connection Monitors, or Packet Captures are targeted at the same subscription.

[lewinski]

I just updated this with code to support the strict import behavior that I saw implemented on a number of other resources recently.

[lewinski]

Acceptance test run:

$ make testacc TESTARGS='-run=TestAccAzureRMNetworkWatcher/ConnectionMonitor'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run=TestAccAzureRMNetworkWatcher/ConnectionMonitor -timeout 180m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
?   	github.com/terraform-providers/terraform-provider-azurerm	[no test files]
=== RUN   TestAccAzureRMNetworkWatcher
=== RUN   TestAccAzureRMNetworkWatcher/ConnectionMonitor
=== RUN   TestAccAzureRMNetworkWatcher/ConnectionMonitor/vmComplete
=== RUN   TestAccAzureRMNetworkWatcher/ConnectionMonitor/destinationUpdate
=== RUN   TestAccAzureRMNetworkWatcher/ConnectionMonitor/missingDestinationInvalid
=== RUN   TestAccAzureRMNetworkWatcher/ConnectionMonitor/addressBasic
=== RUN   TestAccAzureRMNetworkWatcher/ConnectionMonitor/addressUpdate
=== RUN   TestAccAzureRMNetworkWatcher/ConnectionMonitor/vmBasic
=== RUN   TestAccAzureRMNetworkWatcher/ConnectionMonitor/requiresImport
=== RUN   TestAccAzureRMNetworkWatcher/ConnectionMonitor/addressComplete
=== RUN   TestAccAzureRMNetworkWatcher/ConnectionMonitor/vmUpdate
=== RUN   TestAccAzureRMNetworkWatcher/ConnectionMonitor/bothDestinationsInvalid
--- PASS: TestAccAzureRMNetworkWatcher (5840.29s)
    --- PASS: TestAccAzureRMNetworkWatcher/ConnectionMonitor (5840.29s)
        --- PASS: TestAccAzureRMNetworkWatcher/ConnectionMonitor/vmComplete (530.20s)
        --- PASS: TestAccAzureRMNetworkWatcher/ConnectionMonitor/destinationUpdate (924.33s)
        --- PASS: TestAccAzureRMNetworkWatcher/ConnectionMonitor/missingDestinationInvalid (519.28s)
        --- PASS: TestAccAzureRMNetworkWatcher/ConnectionMonitor/addressBasic (557.94s)
        --- PASS: TestAccAzureRMNetworkWatcher/ConnectionMonitor/addressUpdate (921.53s)
        --- PASS: TestAccAzureRMNetworkWatcher/ConnectionMonitor/vmBasic (572.15s)
        --- PASS: TestAccAzureRMNetworkWatcher/ConnectionMonitor/requiresImport (629.02s)
        --- PASS: TestAccAzureRMNetworkWatcher/ConnectionMonitor/addressComplete (526.00s)
        --- PASS: TestAccAzureRMNetworkWatcher/ConnectionMonitor/vmUpdate (659.81s)
        --- PASS: TestAccAzureRMNetworkWatcher/ConnectionMonitor/bothDestinationsInvalid (0.03s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	5840.328s
testing: warning: no tests to run
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm/helpers/azure	0.029s [no tests to run]
testing: warning: no tests to run
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm/helpers/kubernetes	0.007s [no tests to run]
?   	github.com/terraform-providers/terraform-provider-azurerm/azurerm/helpers/response	[no test files]
?   	github.com/terraform-providers/terraform-provider-azurerm/azurerm/helpers/set	[no test files]
testing: warning: no tests to run
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm/helpers/suppress	0.027s [no tests to run]
testing: warning: no tests to run
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm/helpers/tf	0.018s [no tests to run]
testing: warning: no tests to run
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm/helpers/validate	0.024s [no tests to run]
testing: warning: no tests to run
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm/utils	0.030s [no tests to run]
?   	github.com/terraform-providers/terraform-provider-azurerm/version	[no test files]

[katbyte]

Hi @lewinski,

Thank you for this PR! I have given it a lookover and left some mostly minor comments inline. Once those are fixed up this should be good to merge 🙂

[lewinski]

Thanks for the review, @katbyte. I believe I have incorporated all of your feedback into the PR.

[katbyte]

Thanks for the updates @lewinski, LGTM now! will merge once tests pass

[katbyte]

Tests pass:

[22:55:21] kt@snowbook:~/hashi/..3../terraform-providers/terraform-provider-azurerm▸network-watcher-connection-monitor$ testazure TestAccAzureRMNetworkWatcher/ConnectionMonitor
==> Fixing source code with gofmt...
# This logic should match the search logic in scripts/gofmtcheck.sh
gofmt -s -w `find . -name '*.go' | grep -v vendor`
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./azurerm -v -test.run=TestAccAzureRMNetworkWatcher/ConnectionMonitor -timeout 180m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccAzureRMNetworkWatcher
=== RUN   TestAccAzureRMNetworkWatcher/ConnectionMonitor
=== RUN   TestAccAzureRMNetworkWatcher/ConnectionMonitor/addressComplete
=== RUN   TestAccAzureRMNetworkWatcher/ConnectionMonitor/vmBasic
=== RUN   TestAccAzureRMNetworkWatcher/ConnectionMonitor/bothDestinationsInvalid
=== RUN   TestAccAzureRMNetworkWatcher/ConnectionMonitor/addressBasic
=== RUN   TestAccAzureRMNetworkWatcher/ConnectionMonitor/vmComplete
=== RUN   TestAccAzureRMNetworkWatcher/ConnectionMonitor/vmUpdate
=== RUN   TestAccAzureRMNetworkWatcher/ConnectionMonitor/destinationUpdate
=== RUN   TestAccAzureRMNetworkWatcher/ConnectionMonitor/missingDestinationInvalid
=== RUN   TestAccAzureRMNetworkWatcher/ConnectionMonitor/requiresImport
=== RUN   TestAccAzureRMNetworkWatcher/ConnectionMonitor/addressUpdate
--- PASS: TestAccAzureRMNetworkWatcher (6012.62s)
    --- PASS: TestAccAzureRMNetworkWatcher/ConnectionMonitor (6012.62s)
        --- PASS: TestAccAzureRMNetworkWatcher/ConnectionMonitor/addressComplete (538.57s)
        --- PASS: TestAccAzureRMNetworkWatcher/ConnectionMonitor/vmBasic (598.72s)
        --- PASS: TestAccAzureRMNetworkWatcher/ConnectionMonitor/bothDestinationsInvalid (0.04s)
        --- PASS: TestAccAzureRMNetworkWatcher/ConnectionMonitor/addressBasic (756.07s)
        --- PASS: TestAccAzureRMNetworkWatcher/ConnectionMonitor/vmComplete (557.04s)
        --- PASS: TestAccAzureRMNetworkWatcher/ConnectionMonitor/vmUpdate (731.42s)
        --- PASS: TestAccAzureRMNetworkWatcher/ConnectionMonitor/destinationUpdate (956.60s)
        --- PASS: TestAccAzureRMNetworkWatcher/ConnectionMonitor/missingDestinationInvalid (519.27s)
        --- PASS: TestAccAzureRMNetworkWatcher/ConnectionMonitor/requiresImport (582.80s)
        --- PASS: TestAccAzureRMNetworkWatcher/ConnectionMonitor/addressUpdate (772.10s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	6012.663s
[00:35:44] kt@snowbook:~/hashi/..3../terraform-providers/terraform-provider-azurerm▸master-fallback$

[ghost]

This has been released in version 1.23.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
	version = "~> 1.23.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!