Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Loadbalancer Outbound Rule #2912

Merged
merged 12 commits into from
Feb 21, 2019
Merged

Feature: Loadbalancer Outbound Rule #2912

merged 12 commits into from
Feb 21, 2019

Conversation

mcharriere
Copy link
Contributor

@mcharriere mcharriere commented Feb 18, 2019

Add support for Outbound Rules in Standard Load Balancer #1984

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mcharriere,

Thank you for the PR! i've looked over it and aside from some very minor comments it LGTM.

However while running the tests however they all fail with:

Test ended in panic.

------- Stdout: -------
=== RUN   TestAccAzureRMLoadBalancerOutboundRule_reapply
=== PAUSE TestAccAzureRMLoadBalancerOutboundRule_reapply
=== CONT  TestAccAzureRMLoadBalancerOutboundRule_reapply

------- Stderr: -------
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x8 pc=0x1ec251d]

goroutine 381 [running]:
github.com/terraform-providers/terraform-provider-azurerm/azurerm.resourceArmLoadBalancerOutboundRuleCreateUpdate(0xc00052bdc0, 0x28703e0, 0xc000368a80, 0x0, 0x0)
	/opt/teamcity-agent/work/458e5e4800bd94f6/src/github.com/terraform-providers/terraform-provider-azurerm/azurerm/resource_arm_loadbalancer_outbound_rule.go:126 +0x3dd
github.com/terraform-providers/terraform-provider-azurerm/vendor/github.com/hashicorp/terraform/helper/schema.(*Resource).Apply(0xc000577260, 0xc000680b90, 0xc0007e5c00, 0x28703e0, 0xc000368a80, 0xc00062e701, 0x3d, 0x0)
	/opt/teamcity-agent/work/458e5e4800bd94f6/src/github.com/terraform-providers/terraform-provider-azurerm/vendor/github.com/hashicorp/terraform/helper/schema/resource.go:225 +0x351
github.com/terraform-providers/terraform-provider-azurerm/vendor/github.com/hashicorp/terraform/helper/schema.(*Provider).Apply(0xc0004ce380, 0xc0006806e0, 0xc000680b90, 0xc0007e5c00, 0x1, 0x481593, 0x0)
	/opt/teamcity-agent/work/458e5e4800bd94f6/src/github.com/terraform-providers/terraform-provider-azurerm/vendor/github.com/hashicorp/terraform/helper/schema/provider.go:283 +0x9c
github.com/terraform-providers/terraform-provider-azurerm/vendor/github.com/hashicorp/terraform/terraform.(*EvalApply).Eval(0xc00074dd80, 0x2d89c80, 0xc000909790, 0x2, 0x2, 0x28a8dae, 0x4)
	/opt/teamcity-agent/work/458e5e4800bd94f6/src/github.com/terraform-providers/terraform-provider-azurerm/vendor/github.com/hashicorp/terraform/terraform/eval_apply.go:57 +0x226
github.com/terraform-providers/terraform-provider-azurerm/vendor/github.com/hashicorp/terraform/terraform.EvalRaw(0x2d4dae0, 0xc00074dd80, 0x2d89c80, 0xc000909790, 0x0, 0x0, 0x0, 0x0)
	/opt/teamcity-agent/work/458e5e4800bd94f6/src/github.com/terraform-providers/terraform-provider-azurerm/vendor/github.com/hashicorp/terraform/terraform/eval.go:53 +0x156
github.com/terraform-providers/terraform-provider-azurerm/vendor/github.com/hashicorp/terraform/terraform.(*EvalSequence).Eval(0xc0007e4f20, 0x2d89c80, 0xc000909790, 0x2, 0x2, 0x28a8dae, 0x4)
	/opt/teamcity-agent/work/458e5e4800bd94f6/src/github.com/terraform-providers/terraform-provider-azurerm/vendor/github.com/hashicorp/terraform/terraform/eval_sequence.go:14 +0x9c
github.com/terraform-providers/terraform-provider-azurerm/vendor/github.com/hashicorp/terraform/terraform.EvalRaw(0x2d4e020, 0xc0007e4f20, 0x2d89c80, 0xc000909790, 0x25838a0, 0x487c342, 0x2504260, 0xc00031d3d0)
	/opt/teamcity-agent/work/458e5e4800bd94f6/src/github.com/terraform-providers/terraform-provider-azurerm/vendor/github.com/hashicorp/terraform/terraform/eval.go:53 +0x156
github.com/terraform-providers/terraform-provider-azurerm/vendor/github.com/hashicorp/terraform/terraform.Eval(0x2d4e020, 0xc0007e4f20, 0x2d89c80, 0xc000909790, 0xc0007e4f20, 0x2d4e020, 0xc0007e4f20, 0x2ad3040)
	/opt/teamcity-agent/work/458e5e4800bd94f6/src/github.com/terraform-providers/terraform-provider-azurerm/vendor/github.com/hashicorp/terraform/terraform/eval.go:34 +0x4d
github.com/terraform-providers/terraform-provider-azurerm/vendor/github.com/hashicorp/terraform/terraform.(*Graph).walk.func1(0x280ae00, 0xc00000e5d8, 0x0, 0x0)
	/opt/teamcity-agent/work/458e5e4800bd94f6/src/github.com/terraform-providers/terraform-provider-azurerm/vendor/github.com/hashicorp/terraform/terraform/graph.go:126 +0xc45
github.com/terraform-providers/terraform-provider-azurerm/vendor/github.com/hashicorp/terraform/dag.(*Walker).walkVertex(0xc0004bf3b0, 0x280ae00, 0xc00000e5d8, 0xc000986740)
	/opt/teamcity-agent/work/458e5e4800bd94f6/src/github.com/terraform-providers/terraform-provider-azurerm/vendor/github.com/hashicorp/terraform/dag/walk.go:387 +0x367
created by github.com/terraform-providers/terraform-provider-azurerm/vendor/github.com/hashicorp/terraform/dag.(*Walker).Update
	/opt/teamcity-agent/work/458e5e4800bd94f6/src/github.com/terraform-providers/terraform-provider-azurerm/vendor/github.com/hashicorp/terraform/dag/walk.go:310 +0x986

Once we get the test passing this should be good to merge 🙂

@katbyte katbyte added this to the 1.23.0 milestone Feb 21, 2019
@katbyte
Copy link
Collaborator

katbyte commented Feb 21, 2019

Thank you for the updates @mcharriere! tests pass now 💯

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed as couple minor things, i'll push a some fixes now to get this merged now 🙂

azurerm/resource_arm_loadbalancer_outbound_rule.go Outdated Show resolved Hide resolved
website/docs/r/loadbalancer_outbound_rule.html.markdown Outdated Show resolved Hide resolved
website/docs/r/loadbalancer_outbound_rule.html.markdown Outdated Show resolved Hide resolved
@katbyte katbyte merged commit 45294b8 into hashicorp:master Feb 21, 2019
katbyte added a commit that referenced this pull request Feb 21, 2019
@mcharriere
Copy link
Contributor Author

awesome! thanks @katbyte !

@ghost
Copy link

ghost commented Mar 8, 2019

This has been released in version 1.23.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
	version = "~> 1.23.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 24, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants