-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_dns_zone: ability to add a resolution_virtual_network_id #2928
Comments
Any thoughts on this. I'm open to creating a PR myself but would like some feedback on what the correct approach would be before starting on it |
Private DNS zones are in public preview. According to the respective FAQ, the limitation that a vNet must be empty will be lifted once the service is GA. Maybe this helps!? |
Thanks for opening this issue - apologies for the delayed response here! Taking a look into this support for this was added in #1404 - but during the preview period this has been moved into the separate Private DNS Zone resource which has a Thanks! |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
Community Note
Description
Currently there does not appear to be a way to add a virtual network to an existing private dns zone's list of
resolution_virtual_network_ids
.Use case
I have a different terraform plan for each of the different areas of our infrastructure, e.g. shared, staging, production.
In the plan for the
shared
infrastructure, I create a private DNS zone,mycompany.local
.In the plans for
production
orstaging
, I want to add the virtual networks I create to that DNS zone'sresolution_virtual_network_ids
when runningterraform apply
and I want to remove them from the ids when runningterraform destroy
New or Affected Resource(s)
Existing
New
Potential Terraform Configuration
The first option to come to mind is this:
An issue with that is that, from the docs:
Following the above approach would likely lead to a lot of
depends_on
in order to ensure other resources weren't added to the vnet created before the dns zone was updated.Perhaps a way around this would be to add a
private_dns_zone_name
property toazurerm_virtual_network
instead?I'm relatively new to terraform so please holler if this is nonsense. Thanks!
References
The text was updated successfully, but these errors were encountered: