Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_api_management: switch from 2018-06-01-preview to 2018-01-01 api #2958

Merged
merged 1 commit into from
Feb 27, 2019

Conversation

katbyte
Copy link
Collaborator

@katbyte katbyte commented Feb 26, 2019

fixes #2945

@katbyte katbyte added this to the 1.23.0 milestone Feb 26, 2019
@katbyte katbyte requested a review from a team February 26, 2019 23:25
@katbyte
Copy link
Collaborator Author

katbyte commented Feb 26, 2019

tests:

==> Fixing source code with gofmt...
# This logic should match the search logic in scripts/gofmtcheck.sh
gofmt -s -w `find . -name '*.go' | grep -v vendor`
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./azurerm -v -test.run=TestAccAzureRMApiManagement -timeout 180m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccAzureRMApiManagement_basic
=== PAUSE TestAccAzureRMApiManagement_basic
=== RUN   TestAccAzureRMApiManagement_requiresImport
=== PAUSE TestAccAzureRMApiManagement_requiresImport
=== RUN   TestAccAzureRMApiManagement_customProps
=== PAUSE TestAccAzureRMApiManagement_customProps
=== RUN   TestAccAzureRMApiManagement_complete
=== PAUSE TestAccAzureRMApiManagement_complete
=== CONT  TestAccAzureRMApiManagement_basic
=== CONT  TestAccAzureRMApiManagement_complete
=== CONT  TestAccAzureRMApiManagement_customProps
=== CONT  TestAccAzureRMApiManagement_requiresImport
--- PASS: TestAccAzureRMApiManagement_complete (1781.49s)
--- PASS: TestAccAzureRMApiManagement_customProps (1900.65s)
--- PASS: TestAccAzureRMApiManagement_basic (1957.88s)
--- PASS: TestAccAzureRMApiManagement_requiresImport (2203.54s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	2203.589s
[14:26:15] kt@snowbook:~/hashi/..3../terraform-providers/terraform-provider-azurerm▸api/update_api$

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff tombuildsstuff merged commit ffcd16f into master Feb 27, 2019
@tombuildsstuff tombuildsstuff deleted the api/get_off_preview_api branch February 27, 2019 07:48
tombuildsstuff added a commit that referenced this pull request Feb 27, 2019
@ghost
Copy link

ghost commented Mar 8, 2019

This has been released in version 1.23.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
	version = "~> 1.23.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 29, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Destroying API manager fails (MS API change)
3 participants