Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource: azurerm_data_factory_linked_service_sql_server #3205

Merged
merged 7 commits into from
Apr 10, 2019

Conversation

mbfrahry
Copy link
Member

@mbfrahry mbfrahry commented Apr 8, 2019

This PR adds the first linked service for data factory into the azurerm provider. We can move the common pieces of linked services into a umbrella resource as we learn more about what is shared between linked services.

Dependent on #3159

--- PASS: TestAzureRmDataFactoryLinkedServiceConnectionStringDiff (0.00s)
--- PASS: TestAccAzureRMDataFactoryLinkedServiceSQLServer_basic (94.96s)

@katbyte
Copy link
Collaborator

katbyte commented Apr 9, 2019

I'll review this once #3159 is merged and the diff is a tad cleaner

@ghost ghost added size/XL and removed size/XXL labels Apr 9, 2019
@mbfrahry
Copy link
Member Author

mbfrahry commented Apr 9, 2019

@katbyte, this should look a bit cleaner now

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @mbfrahry

Thanks for this PR :)

Taking a look through this mostly LGTM - if we can fix up the minor comments this should otherwise be good to merge 👍

Thanks!

@tombuildsstuff tombuildsstuff merged commit a8f6b06 into master Apr 10, 2019
@tombuildsstuff tombuildsstuff deleted the f-datafactory-linkedservice branch April 10, 2019 06:39
tombuildsstuff added a commit that referenced this pull request Apr 10, 2019
@ghost
Copy link

ghost commented Apr 17, 2019

This has been released in version 1.25.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
	version = "~> 1.25.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented May 10, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators May 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants