Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove "Computed" from schema #3219

Merged
merged 1 commit into from
Apr 16, 2019

Conversation

Lucretius
Copy link
Contributor

Resolves #3146

From the discussion I had in the issue, it looks like this feature can be updated after the resource is spun up. I believe that since it is Computed in the schema, updates to the existing resource are ignored. This helper function is used by both the app_service and app_service_slot resources. The default will be false. If the app service requires a 32 bit resource the effect will be that this needs to be specified.

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for this @Lucretius

@tombuildsstuff
Copy link
Contributor

Tests pass - thanks for this @Lucretius 👍

Screenshot 2019-04-16 at 13 56 02

@tombuildsstuff tombuildsstuff merged commit 2defd7d into hashicorp:master Apr 16, 2019
tombuildsstuff added a commit that referenced this pull request Apr 16, 2019
@ghost
Copy link

ghost commented Apr 17, 2019

This has been released in version 1.25.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
	version = "~> 1.25.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented May 16, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators May 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use_32_bit_worker_process doesn't work
2 participants