Adding UltraSSD to list of sku names when creating a managed disk #3453
Conversation
| @@ -149,6 +149,8 @@ func resourceArmManagedDiskCreateUpdate(d *schema.ResourceData, meta interface{} | |||
| skuName = compute.StandardLRS | |||
| } else if strings.EqualFold(storageAccountType, string(compute.StandardSSDLRS)) { | |||
| skuName = compute.StandardSSDLRS | |||
| } else if strings.EqualFold(storageAccountType, string(compute.UltraSSDLRS)) { | |||
There was a problem hiding this comment.
🤔
Is there a reason this entire if/else block isn't just:
skuName = string(compute.storageAccountType)There was a problem hiding this comment.
Good point, I was just mimicking the existing structure, but I am happy to change it.
There was a problem hiding this comment.
In talking with the team it seems like there is a reason behind this, as we are going to release later today i'm just going to merge it in as is and can revisit it at a later time
|
This has been released in version 1.28.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 1.28.0"
}
# ... other configuration ... |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
Though UltraSSD was added back in 1.18.0 (#2118), it appears that it is not properly passing the SKU name. This properly sets the SKU name when creating the disk.
Fixes #3306