Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support multiple agent pool profiles #3491

Merged
merged 4 commits into from
May 23, 2019

Conversation

titilambert
Copy link
Contributor

Hello,

This small patch, enable multi agent pool profiles. It lets users put multiple agent_pool_profile blocks

resource "azurerm_kubernetes_cluster" "aks" {
  ...
  agent_pool_profile {
     name  = "Linux"
      ...
  }
  agent_pool_profile {
     name  = "Windows"
      ...
  }
  ...
}

@ghost ghost added the size/S label May 21, 2019
@dominik-lekse
Copy link
Contributor

@titilambert Thanks for this. Could you add a test case covering multiple agent_pool_profile blocks. I would keep it simple in the beginning and use two Linux based agent pools.

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @titilambert,

Thanks for the PR. Addition to what @dominik-lekse mentioned, you will also need to update the flatten function & documentation.

@djsly
Copy link
Contributor

djsly commented May 22, 2019

@dominik-lekse / @katbyte , we will be tackling the Windows Agent Pool right after, do you know if there is some work in progress ? WE looked but couldn't find it.

@ghost ghost removed the waiting-response label May 22, 2019
@djsly
Copy link
Contributor

djsly commented May 22, 2019

#3478
#3493

@titilambert
Copy link
Contributor Author

Hi @titilambert,

Thanks for the PR. Addition to what @dominik-lekse mentioned, you will also need to update the flatten function & documentation.

Which flatten function are you talking about ? this one flattenKubernetesClusterAgentPoolProfiles ? If so, It's already multiple profile compatible

@ghost ghost removed the waiting-response label May 22, 2019
@tombuildsstuff
Copy link
Contributor

@titilambert

Which flatten function are you talking about ? this one flattenKubernetesClusterAgentPoolProfiles ? If so, It's already multiple profile compatible

Agreed the flatten function's fine here - aside from a missing acceptance test with multiple node pools (example) and updating the documentation to remove the limitation) this otherwise LGTM 👍

@ghost ghost added size/M and removed size/S labels May 22, 2019
@titilambert
Copy link
Contributor Author

Test added

@ghost ghost removed the waiting-response label May 22, 2019
@ghost ghost added the documentation label May 22, 2019
@titilambert
Copy link
Contributor Author

Doc added

@titilambert
Copy link
Contributor Author

Should I patch azurerm/data_source_kubernetes_cluster.go ?

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @titilambert

Thanks for pushing those changes - taking a look through, besides removing one comment in the documentation (so that multiple node pools are now allowed, which I hope you don't mind but I'll push a commit for) - this now LGTM 👍

Thanks!

@tombuildsstuff tombuildsstuff dismissed katbyte’s stale review May 23, 2019 06:07

dismissing since changes have been pushed

@tombuildsstuff
Copy link
Contributor

Ignoring some known/transitory test failures - the tests pass:

Screenshot 2019-05-23 at 09 24 29

@tombuildsstuff tombuildsstuff merged commit eafa812 into hashicorp:master May 23, 2019
tombuildsstuff added a commit that referenced this pull request May 23, 2019
@ghost
Copy link

ghost commented May 26, 2019

This has been released in version 1.29.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
	version = "~> 1.29.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Jun 22, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Jun 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants