Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/storage_queue: switching to use the new SDK #3832

Merged
merged 6 commits into from
Jul 12, 2019
Merged

Conversation

tombuildsstuff
Copy link
Contributor

This PR switches the azurerm_storage_queue resource over to using the new SDK. It also adds support for configuring MetaData (support for the larger service_properties field will come in a subsequent PR)

@tombuildsstuff tombuildsstuff added this to the v1.32.0 milestone Jul 11, 2019
@tombuildsstuff tombuildsstuff requested review from a team and removed request for a team July 11, 2019 18:38
@tombuildsstuff tombuildsstuff changed the title r/storage_queue: switching to use the new SDK [WIP] r/storage_queue: switching to use the new SDK Jul 11, 2019
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from a few minor comments LGTM 👍

azurerm/resource_arm_storage_queue.go Outdated Show resolved Hide resolved
azurerm/resource_arm_storage_queue.go Outdated Show resolved Hide resolved
azurerm/resource_arm_storage_queue_test.go Show resolved Hide resolved
azurerm/resource_arm_storage_queue_test.go Show resolved Hide resolved
@tombuildsstuff tombuildsstuff changed the title [WIP] r/storage_queue: switching to use the new SDK r/storage_queue: switching to use the new SDK Jul 12, 2019
@tombuildsstuff tombuildsstuff merged commit 00daa48 into master Jul 12, 2019
@tombuildsstuff tombuildsstuff deleted the f/storage-queue branch July 12, 2019 07:25
@ghost
Copy link

ghost commented Jul 30, 2019

This has been released in version 1.32.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.32.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Aug 11, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Aug 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants