Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_kubernetes_cluster: Support for kubeDashboard addon profile #4139

Merged

Conversation

dominik-lekse
Copy link
Contributor

Description

  • Add support for the AKS addon profile "kubeDashboard" in azurerm_kubernetes_cluster
  • Allows to disable the default Kubernetes Dashboard in an AKS cluster

References

Tasks

  • Research for the property to set
  • Implementation in resource
  • Tests for resource
  • Documentation of resource
  • Implementation in data source
  • Tests for data source
  • Documentation of data source

Notes on test runs

I have not run the full test suite of the azurerm_kubernetes_cluster resource and data source due to resource limitations and the complexity of the Azure Kubernetes Cluster resource. I would kindly ask the HashiCorp or Microsoft Azure team to proceed with the test runs.

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @dominik-lekse

Thanks for this PR - apologies for the delayed review here!

Taking a look through this LGTM - I'll kick off the tests now 👍

Thanks!

@tombuildsstuff tombuildsstuff added this to the v1.34.0 milestone Aug 28, 2019
@tombuildsstuff
Copy link
Contributor

Ignoring some internal AKS errors we see from time to time (InternalServerError/NodesNotReady) failures the tests otherwise LGTM 👍

@tombuildsstuff tombuildsstuff merged commit ba48c53 into hashicorp:master Aug 29, 2019
tombuildsstuff added a commit that referenced this pull request Aug 29, 2019
@dominik-lekse
Copy link
Contributor Author

Thanks @tombuildsstuff

@ghost
Copy link

ghost commented Sep 18, 2019

This has been released in version 1.34.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.34.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Sep 28, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Sep 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants