Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request - azurerm_storage_account - VNet Endpoint Support #416

Closed
JasonNguyenTX opened this issue Oct 11, 2017 · 13 comments
Closed

Comments

@JasonNguyenTX
Copy link

Request that azurerm_storage_account to support VNet Endpoint so that when storage account is created, VNet Endpoint/firewall can be configured to control access to storage account

@tombuildsstuff tombuildsstuff changed the title Feature request - VNet Endpoint Support Feature request - azurerm_storage_account - VNet Endpoint Support Oct 11, 2017
@rcarun rcarun added this to the M1 milestone Oct 12, 2017
@JasonNguyenTX
Copy link
Author

Based on MS doc: https://docs.microsoft.com/en-us/azure/virtual-network/virtual-network-service-endpoints-configure, the service endpoints for storage and sql can be enabled when creating virtual network, would it make more sense to enable it from there?

@mattpound808
Copy link

Hi,

Any news on when this might get implemented now the feature has gone GA please ?

https://azure.microsoft.com/en-gb/blog/virtual-network-service-endpoints-and-firewalls-for-azure-storage-now-generally-available/

Thank you

@murraypete
Copy link

+1 - would be great to see this implemented

@HighwayofLife
Copy link

Copied from #1110

Feature Request: Add support for Storage Account Firewall and Network Rules.

Affected Resource(s)

  • azurerm_storage_account
  • azurerm_subnet

Subnets need to be able to create service endpoints. (see below ARM snippet)

References

ARM Template snippet - Storage

"kind": "Storage",
"name": "[parameters('storageAccounts_devworkdiag410_name')]",
"apiVersion": "2017-10-01",
"location": "eastus2",
"tags": {},
"scale": null,
"properties": {
    "networkAcls": {
        "bypass": "AzureServices",
        "virtualNetworkRules": [
            {
                "id": "[resourceId('Microsoft.Network/virtualNetworks/subnets', parameters('virtualNetworks_DevWork_vnet_name'), parameters('subnets_default_name'))]",
                "action": "Allow",
                "state": "Succeeded"
            }
        ],
        "ipRules": [],
        "defaultAction": "Deny"
    },

ARM Template snippet - Subnet

"type": "Microsoft.Network/virtualNetworks/subnets",
"name": "[concat(parameters('virtualNetworks_DevWork_vnet_name'), '/', parameters('subnets_default_name'))]",
"apiVersion": "2018-01-01",
"scale": null,
"properties": {
    "provisioningState": "Succeeded",
    "addressPrefix": "10.0.0.0/24",
    "serviceEndpoints": [
        {
            "provisioningState": "Succeeded",
            "service": "Microsoft.Storage",
            "locations": [
                "eastus2",
                "centralus"
            ]
        }
    ]
}

@steffencircle
Copy link

steffencircle commented Jun 1, 2018

Hi,

are there any news update this feature ?
It's kind of critical for us in order to be able to secure some services.

@tombuildsstuff
Copy link
Contributor

@lw81 this is something we plan to do soon (I believe @mbfrahry may be taking a look into this, actually?) - but we can't give a more specific timeframe at the moment unfortunately. In the interim you should be able to achieve the same thing using the azurerm_template_deployment resource to provision this functionality.

@mbfrahry
Copy link
Member

mbfrahry commented Jun 1, 2018

@lw81, I've got a PR open addressing this issue.

@jondkent
Copy link

jondkent commented Jun 4, 2018

Hi,

Another vote for this. We really need this to restrict access to storage accounts.

Cheers,
Jon

@mbfrahry
Copy link
Member

mbfrahry commented Jun 5, 2018

Hey all! This feature has been merged in #1334 so I'm closing this issue and we'll have it in the next release

@mbfrahry mbfrahry closed this as completed Jun 5, 2018
@katbyte
Copy link
Collaborator

katbyte commented Jun 16, 2018

@JasonNguyenTX, @jondkent, @lw81, @HighwayofLife, @murraypete, @mattpound808,

Just a friendly heads up that this was included in 1.7 that was released today. I hope it resolves all the issues everyone was having!

@steffencircle
Copy link

Awesome. Implemting this in our code right now. Many thanks

@murraypete
Copy link

Nice - thanks all!

@tombuildsstuff tombuildsstuff modified the milestones: Soon, Being Sorted Oct 25, 2018
@tombuildsstuff tombuildsstuff removed this from the Being Sorted milestone Oct 25, 2018
@ghost
Copy link

ghost commented Mar 6, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests