Fields missing from first release of Azure Application Gateway Resource

[isaacsgi]

• Firewall Disabled Rule Groups
• SSL Policies

---

Resource mapping code is missing some detailed attributes of elements in current Azure REST API:
**webApplicationFirewallConfiguration[i].disabledRuleGroups**
"disabledRuleGroups": {
          "type": "array",
          "items": {
            "$ref": "#/definitions/ApplicationGatewayFirewallDisabledRuleGroup"
          },
          "description": "The disabled rule groups."
        }
    "ApplicationGatewayFirewallDisabledRuleGroup": {
      "properties": {
        "ruleGroupName": {
          "type": "string",
          "description": "The name of the rule group that will be disabled."
        },
        "rules": {
          "type": "array",
          "items": {
            "type": "integer",
            "format": "int32",
            "x-nullable": false
          },
          "description": "The list of rules that will be disabled. If null, all rules of the rule group will be disabled."
        }
      },
      "required": [
        "ruleGroupName"
      ],
      "description": "Allows to disable rules within a rule group or an entire rule group."
    },
**"ApplicationGatewaySslPolicy":** {
      "properties": {
        "disabledSslProtocols": {
          "type": "array",
          "description": "Ssl protocols to be disabled on application gateway.",
          "items":{
            "type": "string",
            "$ref": "#/definitions/ProtocolsEnum",
            "x-ms-enum": {
              "name": "ApplicationGatewaySslProtocol",
              "modelAsString": true
            }
          }
        },
        "policyType": {
          "type": "string",
          "description": "Type of Ssl Policy",
          "enum": [
            "Predefined",
            "Custom"
          ],
          "x-ms-enum": {
            "name": "ApplicationGatewaySslPolicyType",
            "modelAsString": true
          }
        },
        "policyName":{
          "$ref": "#/definitions/PolicyNameEnum",
          "description": "Name of Ssl predefined policy"
        },
        "cipherSuites":{
          "type": "array",
          "items":{
            "$ref": "#/definitions/CipherSuitesEnum"
          },
          "description":"Ssl cipher suites to be enabled in the specified order to application gateway."\
        },
        "minProtocolVersion":{
          "$ref": "#/definitions/ProtocolsEnum",
          "description": "Minimum version of Ssl protocol to be supported on application gateway."
        }
      },
      "description": "Application Gateway Ssl policy."
    }

References

Following from the initial release/first merge with main of the Application Gateway Resource: #413
Also based on this version of the Azure REST API:
https://github.com/Azure/azure-rest-api-specs/blob/current/specification/network/resource-manager/Microsoft.Network/2017-08-01/applicationGateway.json

[katbyte]

Blocked on API fixes

[tombuildsstuff]

hi @isaacsgi

Given this issue is blocked on an upstream issue in the Azure API rather than keeping multiple issues open and trying to ensure they all remain up to date - I'm going to close this in favour of #1576 which is the Meta-Issue tracking the Bugs and Enhancements for the Application Gateway Resource. Once the bug in the API is fixed we should be able to take a look into this, but we'll keep track of the status of this issue there for the moment.

Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!