[azurerm_key_vault_certificate] - switches the emails, dns_names , upns of the subject_alternative_names property to use TypeSet

[hbuckle]

I noticed when importing an existing certificate these properties did not come back in the same order as the configuration, so Terraform wanted to recreate the certificate.

[katbyte]

Hi @hbuckle,

You are entirely correct these should be a set. However its not so easy to simply change the type. You are also going to need to update the flatten&expand functions to handle the fact its no longer an list:

Test ended in panic.

------- Stdout: -------
=== RUN   TestAccAzureRMKeyVaultCertificate_basicGenerateSans
=== PAUSE TestAccAzureRMKeyVaultCertificate_basicGenerateSans
=== CONT  TestAccAzureRMKeyVaultCertificate_basicGenerateSans

------- Stderr: -------
2019/10/18 13:45:19 [DEBUG] Registering Data Sources for "Compute"..
2019/10/18 13:45:19 [DEBUG] Registering Resources for "Compute"..
panic: interface conversion: interface {} is *schema.Set, not []interface {}

[hbuckle]

@katbyte yes of course, now updated

[katbyte]

Thanks @hbuckle!

Tests pass and LGTM now 👍

[ghost]

This has been released in version 1.36.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.36.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!