Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_mysql_server - add support for version 8.0 #5019

Merged
merged 3 commits into from
Nov 28, 2019
Merged

azurerm_mysql_server - add support for version 8.0 #5019

merged 3 commits into from
Nov 28, 2019

Conversation

aqche
Copy link
Contributor

@aqche aqche commented Nov 28, 2019

Fixes: #4380

Adds 8.0 as a valid value for azurerm_mysql_server's version argument to support creating a MySQL server version 8.0.

=== RUN   TestAccAzureRMMySQLServer_basicEightZero
=== PAUSE TestAccAzureRMMySQLServer_basicEightZero
=== CONT  TestAccAzureRMMySQLServer_basicEightZero
--- PASS: TestAccAzureRMMySQLServer_basicEightZero (359.53s)
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm       359.585s

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @aqche

Thanks for this PR :)

Taking a look through this is looking good - if we can just add a link to the Swagger then this otherwise LGTM 👍

Thanks!

azurerm/resource_arm_mysql_server.go Outdated Show resolved Hide resolved
@tombuildsstuff tombuildsstuff added this to the v1.38.0 milestone Nov 28, 2019
@aqche
Copy link
Contributor Author

aqche commented Nov 28, 2019

@tombuildsstuff thanks for the quick review. added the link :)

@tombuildsstuff tombuildsstuff merged commit 1ae4792 into hashicorp:master Nov 28, 2019
tombuildsstuff added a commit that referenced this pull request Nov 28, 2019
@aqche aqche deleted the support_mysql_server_ver_8.0 branch November 29, 2019 04:15
@ghost
Copy link

ghost commented Dec 7, 2019

This has been released in version 1.38.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.38.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Dec 29, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Dec 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_mysql_server - add support for version 8.0
2 participants