Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Healthcare resource. CORS block is fixed to avoid unnecessary diffs #5046

Merged

Conversation

kutsovmqs
Copy link
Contributor

@kutsovmqs kutsovmqs commented Dec 3, 2019

The issue is that default CORS values are create in Azure, even if none are specified in the TF script. If none are specified in the TF script then any TF plan or apply will see that there is a CORS Configuration and want to delete it accordingly, since it's not in the script.

@ghost ghost added the size/XS label Dec 3, 2019
@kutsovmqs kutsovmqs changed the title CORS block is fixed to avoid unnecessary diffs Healthcare resource. CORS block is fixed to avoid unnecessary diffs Dec 4, 2019
@kutsovmqs
Copy link
Contributor Author

Hi @tombuildsstuff . Could you tell me what I need to do to move this PR forward?

@tombuildsstuff tombuildsstuff self-assigned this Dec 17, 2019
@tombuildsstuff tombuildsstuff added this to the v1.40.0 milestone Dec 17, 2019
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @kutsovmqs

Thanks for this PR - apologies for the delayed review here!

Taking a look through this LGTM - I'll kick off the tests now 👍

Thanks!

@tombuildsstuff
Copy link
Contributor

Running the tests for this and comparing them with master - both are currently failing due to a behavioural change in the API; as such I'm going to merge this for the moment then send a second PR to fix that up - thanks again @kutsovmqs

@tombuildsstuff tombuildsstuff merged commit e4c94be into hashicorp:master Dec 17, 2019
tombuildsstuff added a commit that referenced this pull request Dec 17, 2019
@ghost
Copy link

ghost commented Jan 8, 2020

This has been released in version 1.40.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.40.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants