Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Azure Backup and Azure Site Recovery resources #5170

Merged
merged 13 commits into from
Dec 19, 2019

Conversation

sean-nixon
Copy link
Contributor

Fixes #5089

This PR implements the proposed changes in the above issue to better distinguish Azure Site Recovery and Azure Backup resources.

Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small change and a make fmt and I think we're good. Thanks for opening this @sean-nixon

@@ -7,7 +7,9 @@ description: |-
Manages a site recovery services protection container mappings on Azure.
---

# azurerm_recovery_replicated_vm
# azurerm_replicated_vm
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this still wants to be azurerm_recovery_replicated_vm

@@ -211,6 +211,8 @@ func Provider() terraform.ResourceProvider {
"azurerm_azuread_application": resourceArmActiveDirectoryApplication(),
"azurerm_azuread_service_principal_password": resourceArmActiveDirectoryServicePrincipalPassword(),
"azurerm_azuread_service_principal": resourceArmActiveDirectoryServicePrincipal(),
"azurerm_backup_protected_vm": resourceArmRecoveryServicesBackupProtectedVM(),
"azurerm_backup_policy_vm": resourceArmBackupProtectionPolicyVM(),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we need to run make fmt

@tombuildsstuff tombuildsstuff added this to the v1.40.0 milestone Dec 18, 2019
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@katbyte katbyte merged commit 16a3c45 into hashicorp:master Dec 19, 2019
katbyte added a commit that referenced this pull request Dec 19, 2019
katbyte pushed a commit that referenced this pull request Dec 19, 2019
Addresses #5026

An additional resource beyond the suggested resources in the associated issue was required in order to first register a storage account with a recovery services vault. I've also used an updated naming scheme based on my proposal in #5089 and associated PR #5170 in order to better distinguish Azure Backup resources from Site Recovery (DR) resources. That PR does not technically block this one, but it would make the naming more consistent with the existing Azure Backup resources.
@sean-nixon sean-nixon deleted the recovery-services-refactor branch December 19, 2019 14:15
@ghost
Copy link

ghost commented Jan 8, 2020

This has been released in version 1.40.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.40.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal: Better distinguish Site Recovery and Azure Backup resource names
4 participants