Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_log_profile wait for stable state #5194

Merged
merged 4 commits into from
Dec 17, 2019

Conversation

tiwood
Copy link
Contributor

@tiwood tiwood commented Dec 17, 2019

Our CI/CD pipeline for our infrastructure components fails sometimes due to replication lag while creating log profiles.

This PR should fix this by waiting for a stable state.

Fixes #4559

@ghost ghost added the size/XS label Dec 17, 2019
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for this @tiwood

@ghost ghost added size/S and removed size/XS labels Dec 17, 2019
@tiwood
Copy link
Contributor Author

tiwood commented Dec 17, 2019

@tombuildsstuff, I’ve pushed the requested changes.

@tombuildsstuff tombuildsstuff added this to the v1.40.0 milestone Dec 17, 2019
@tombuildsstuff tombuildsstuff merged commit fb52a09 into hashicorp:master Dec 17, 2019
tombuildsstuff added a commit that referenced this pull request Dec 17, 2019
@ghost
Copy link

ghost commented Jan 8, 2020

This has been released in version 1.40.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.40.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_log_profile creation fails due to replication lag
2 participants