Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add enable_tcp_reset to azurerm_lb_rule & azurerm_lb_nat_rule #5373

Merged
merged 3 commits into from
Jan 13, 2020

Conversation

katbyte
Copy link
Collaborator

@katbyte katbyte commented Jan 12, 2020

fixes #3404

also adds idle_timeout_in_minutes toazurerm_lb_nat_rule

@katbyte katbyte added this to the v1.41.0 milestone Jan 12, 2020
@katbyte katbyte requested a review from a team January 12, 2020 01:48
@katbyte katbyte changed the title add enable_tcp_reset to azurerm_lb_rule & azurerm_lb_natrule add enable_tcp_reset to azurerm_lb_rule & azurerm_lb_nat_rule Jan 12, 2020
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few minor comments but this otherwise LGTM 👍

@tombuildsstuff
Copy link
Contributor

Tests pass:

Screenshot 2020-01-13 at 17 00 03

@katbyte katbyte merged commit 612c58b into master Jan 13, 2020
@katbyte katbyte deleted the kt/lb-nat-rule-options branch January 13, 2020 17:15
katbyte added a commit that referenced this pull request Jan 13, 2020
@ghost
Copy link

ghost commented Jan 16, 2020

This has been released in version 1.41.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.41.0"
}
# ... other configuration ...

@ghost ghost removed the waiting-response label Jan 16, 2020
@ghost
Copy link

ghost commented Mar 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add enableTcpReset parameter for Standard Load Balancer rules and nat rules
2 participants