azurerm_mysql_virtual_network_rule - remove subnet cfg check as its no longer required

[titilambert]

Fixs #4392

[katbyte]

Hi @titilambert,

Could we get a test with an improperly configured subnet to verify that the api has actually been fixed? thanks!

[titilambert]

Hi @titilambert,

Could we get a test with an improperly configured subnet to verify that the api has actually been fixed? thanks!

Thanks for your answer !
Do you have an example to see how to do it correctly ? (I don't find one)

Thanks

[katbyte]

@titilambert,

You can take an existing test and create a new one where in the:

resource "azurerm_subnet" "test" {
  name                 = "acctestsubnet%d"
  resource_group_name  = "${azurerm_resource_group.test.name}"
  virtual_network_name = "${azurerm_virtual_network.test.name}"
  address_prefix       = "10.7.29.0/29"
  service_endpoints    = ["Microsoft.Sql"]
}

section remove the service_endpoints = ["Microsoft.Sql"] line and see what happens.

[titilambert]

@katbyte Thanks

....... make acctests SERVICE='mysql' TESTARGS='-run=TestAccAzureRMMySqlVirtualNetworkRule_badsubnet'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
TF_ACC=1 go test -v ./azurerm/internal/services/mysql/tests/ -run=TestAccAzureRMMySqlVirtualNetworkRule_badsubnet -timeout 180m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccAzureRMMySqlVirtualNetworkRule_badsubnet
=== PAUSE TestAccAzureRMMySqlVirtualNetworkRule_badsubnet
=== CONT  TestAccAzureRMMySqlVirtualNetworkRule_badsubnet

--- PASS: TestAccAzureRMMySqlVirtualNetworkRule_badsubnet (381.34s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/mysql/tests	381.353s

[katbyte]

Thanks @titilambert! LGTM now

[ghost]

This has been released in version 1.43.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.43.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!