Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_key_vault_key - support for not_before_date and expiration_date #5619

Merged
merged 1 commit into from
Feb 7, 2020
Merged

azurerm_key_vault_key - support for not_before_date and expiration_date #5619

merged 1 commit into from
Feb 7, 2020

Conversation

aqche
Copy link
Contributor

@aqche aqche commented Feb 5, 2020

Fixes #5615

Adds the not_before_date and expiration_date options to the azurerm_key_vault_key resource.

--- PASS: TestAccAzureRMKeyVaultKey_disappears (207.17s)
--- PASS: TestAccAzureRMKeyVaultKey_basicRSAHSM (230.35s)
--- PASS: TestAccAzureRMKeyVaultKey_complete (238.66s)
--- PASS: TestAccAzureRMKeyVaultKey_basicECClassic (238.66s)
--- PASS: TestAccAzureRMKeyVaultKey_basicECHSM (239.90s)
--- PASS: TestAccAzureRMKeyVaultKey_basicEC (242.53s)
--- PASS: TestAccAzureRMKeyVaultKey_curveEC (247.80s)
--- PASS: TestAccAzureRMKeyVaultKey_update (260.65s)
--- PASS: TestAccAzureRMKeyVaultKey_disappearsWhenParentKeyVaultDeleted (267.47s)
--- PASS: TestAccAzureRMKeyVaultKey_basicRSA (269.74s)
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/keyvault/tests      269.769s

Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mbfrahry mbfrahry merged commit 543558b into hashicorp:master Feb 7, 2020
@aqche aqche deleted the azurerm_key_vault_key_date_options branch February 8, 2020 07:27
@ghost
Copy link

ghost commented Mar 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Azure Key Vault Key creation with activation/expiration date
2 participants