Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_virtual_machine_data_disk_attachment should be invalidated if VM does not exist #6297

Closed
privatwolke opened this issue Mar 30, 2020 · 2 comments
Labels
bug duplicate service/disk-attachments Virtual Machine Disk Attachments
Milestone

Comments

@privatwolke
Copy link
Contributor

If external forces get rid of a VM the provider should also invalidate data disk attachments. A plan involving a VM + data disk attachment would then propose to create both resources.

Reference

https://github.com/terraform-providers/terraform-provider-azurerm/blob/211a7324ff496d61ad6b95a365e025a4c6c83756/azurerm/internal/services/compute/resource_arm_virtual_machine_data_disk_attachment.go#L113

@tombuildsstuff tombuildsstuff added bug duplicate service/disk-attachments Virtual Machine Disk Attachments labels Mar 30, 2020
@tombuildsstuff tombuildsstuff added this to the v2.3.0 milestone Mar 30, 2020
@tombuildsstuff
Copy link
Contributor

hi @privatwolke

Thanks for opening this issue :)

The fix for this got merged into #6237 which shipped in version 2.3.0 of the Azure Provider - would you be able to take a look and see if that works for you? Since this appears to be resolved I'm going to close this issue for the moment - however please let us know if that doesn't work for you and we'll take another look.

Thanks!

@ghost
Copy link

ghost commented Apr 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug duplicate service/disk-attachments Virtual Machine Disk Attachments
Projects
None yet
Development

No branches or pull requests

2 participants