Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Data Source: azurerm_app_service_plan #668

Merged
merged 1 commit into from
Jan 8, 2018

Conversation

tombuildsstuff
Copy link
Contributor

Whilst reviewing #647 I realised this could be a useful Data Source - as such I've added one with the same properties visible on the Resource.

Tests pass:

$ acctests azurerm TestAccDataSourceAzureRMAppServicePlan_
=== RUN   TestAccDataSourceAzureRMAppServicePlan_basic
--- PASS: TestAccDataSourceAzureRMAppServicePlan_basic (79.79s)
=== RUN   TestAccDataSourceAzureRMAppServicePlan_complete
--- PASS: TestAccDataSourceAzureRMAppServicePlan_complete (74.04s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	153.860s

Tests pass:

```
$ acctests azurerm TestAccDataSourceAzureRMAppServicePlan_
=== RUN   TestAccDataSourceAzureRMAppServicePlan_basic
--- PASS: TestAccDataSourceAzureRMAppServicePlan_basic (79.79s)
=== RUN   TestAccDataSourceAzureRMAppServicePlan_complete
--- PASS: TestAccDataSourceAzureRMAppServicePlan_complete (74.04s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	153.860s
```
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tombuildsstuff tombuildsstuff merged commit 4863fe1 into master Jan 8, 2018
@tombuildsstuff tombuildsstuff deleted the app-service-plan-data-source branch January 8, 2018 16:42
tombuildsstuff added a commit that referenced this pull request Jan 8, 2018
@ghost
Copy link

ghost commented Apr 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants