Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to update tags (OR the lack of tags support) for the azurerm_redis_cache resource #67

Closed
hashibot opened this issue Jun 13, 2017 · 3 comments

Comments

@hashibot
Copy link

This issue was originally opened by @horsey as hashicorp/terraform#13892. It was migrated here as part of the provider split. The original body of the issue is below.


Terraform Version

v0.9.2

Affected Resource(s)

azurerm_redis_cache

Terraform Configuration Files

resource "azurerm_redis_cache" "redis" {
    name                = "redis1"
    location            = "East US"
    resource_group_name = "${azurerm_resource_group.production.name}"
    capacity            = 1
    family              = "C"
    sku_name            = "Standard"
    enable_non_ssl_port = false

    redis_configuration {
        maxclients = "1000"
    }

    tags {
        role = "redis"
        environment = "production"
    }
}

Debug Output

https://gist.github.com/horsey/355b4caa85cb10b3135d828fc554c63b

Panic Output

None

Expected Behavior

The tags updated inside the .tf file should reflect on the resource.

Actual Behavior

Terraform converges successfully saying that the tags were updated, but one can't see the tags on the portal.

Steps to Reproduce

  1. Create a azurerm_redis_cache resource with empty tags.
  2. Converge the resource successfully.
  3. Update tags as shown in the snippet above.
  4. terraform apply

Important Factoids

When the azurerm_redis_cache resource was converged for the first time, the resource did not have any tag field absolutely. It was not checked if the tags were added to the resource for the first time.

References

None.

@tombuildsstuff
Copy link
Contributor

Hey @horsey

To provide an update here - the Swagger is wrong for the Update function and should allow Tags to be specified on the top level object, rather than within the Properties object - which is why this is not working.

Once the Swagger/SDK has been updated - we can progress with this

Thanks!

@tombuildsstuff tombuildsstuff removed their assignment Jun 28, 2017
@achandmsft achandmsft added this to the 1.4.0 milestone Mar 10, 2018
@tombuildsstuff
Copy link
Contributor

Support for Tags in the azurerm_redis_cache resource has been added in #1086 which will ship as part of v1.3.3 of the AzureRM Provider which should be shipping soon; as such I'm going to close this issue for the moment.

@tombuildsstuff tombuildsstuff modified the milestones: 1.4.0, 1.3.3 Apr 17, 2018
@ghost
Copy link

ghost commented Mar 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants