Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_automation_account DS set its own ID #6848

Merged
merged 2 commits into from
May 11, 2020

Conversation

magodo
Copy link
Collaborator

@magodo magodo commented May 11, 2020

Previously, it uses the automation account agent registration info's ID
as its ID, which causes other resources which refers to that ID will fail
to parse the resource ID (as it doesn't apply to resource ID format).

Nevertheless, we shall change to use the ID of the resource
azurerm_automation_account as the DS's ID.

Fixes: #6746

Test Result

💤 😡 2 via 🦉 v1.14.2 make testacc TEST=./azurerm/internal/services/automation/tests TESTARGS="-run TestAccDataSourceAutomationAccount"
==> Checking that code complies with gofmt requirements...                                                                                   
==> Checking that Custom Timeouts are used...                                                                                                
TF_ACC=1 go test ./azurerm/internal/services/automation/tests -v -run TestAccDataSourceAutomationAccount -timeout 180m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccDataSourceAutomationAccount                                                                                                 
=== PAUSE TestAccDataSourceAutomationAccount                                                                                                 
=== CONT  TestAccDataSourceAutomationAccount                                                                                                 
--- PASS: TestAccDataSourceAutomationAccount (183.86s)                                                                                       
PASS                                                                                                                                         
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/automation/tests    183.878s     

magodo added 2 commits May 9, 2020 16:29
Previously, it uses the automation account agent registration info's ID
as its ID, which cause other resource which refers to that ID will fail
to parse the resource ID (as it doesn't apply to resource ID format).

Nevertheless, we shall change to use the ID of resource
`azurerm_automation_account` as the DS's ID.
@ghost ghost added the size/XS label May 11, 2020
@tombuildsstuff tombuildsstuff added this to the v2.10.0 milestone May 11, 2020
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff tombuildsstuff merged commit cb5e732 into hashicorp:master May 11, 2020
tombuildsstuff added a commit that referenced this pull request May 11, 2020
jrauschenbusch pushed a commit to jrauschenbusch/terraform-provider-azurerm that referenced this pull request May 13, 2020
@ghost
Copy link

ghost commented May 15, 2020

This has been released in version 2.10.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.10.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Jun 10, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Jun 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can not parse "resource_id" as a resource id: Key/Value cannot be empty strings
2 participants