Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for publicNetworkAccess property on azurerm_container_registry #7334

Closed
adrianmo opened this issue Jun 16, 2020 · 3 comments
Closed

Comments

@adrianmo
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

The latest API version for the Microsoft.ContainerRegistry/registries Azure resource, i.e., 2019-12-01-preview at the time of writing, has a property called publicNetworkAccess to enable or disable public network access to the registry.

The publicNetworkAccess property is optional and its type is Enum with allowed values of "Enabled" or "Disabled". The default value is "Enabled".

From the AZ CLI, this property is set via a boolean argument.

$ az acr create --help
...
    --public-network-enabled       : Allow public network access for the container registry. The
                                     Default is allowed.  Allowed values: false, true.
...

New or Affected Resource(s)

  • azurerm_container_registry

Potential Terraform Configuration

resource "azurerm_container_registry" "acr" {
  name                     = "containerRegistry1"
  resource_group_name      = azurerm_resource_group.rg.name
  location                 = azurerm_resource_group.rg.location
  sku                      = "Premium"
  admin_enabled            = false
  georeplication_locations = ["East US", "West Europe"]
  public_network_enabled   = false
}

References

@masonhuemmer
Copy link

When is this feature going to be available?

@tombuildsstuff
Copy link
Contributor

Fixed via #10969

@ghost
Copy link

ghost commented May 8, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators May 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

7 participants