Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nil check route filter before set in express_route_circuit #7776

Merged
merged 2 commits into from
Jul 16, 2020

Conversation

jackofallops
Copy link
Member

No description provided.

@jackofallops jackofallops added this to the v2.19.0 milestone Jul 16, 2020
@jackofallops jackofallops requested a review from a team July 16, 2020 07:53
@ghost ghost added the size/XS label Jul 16, 2020
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we can fix that then this otherwise LGTM 👍

@jackofallops
Copy link
Member Author

Test passing (1 transient failure)
image

@jackofallops jackofallops merged commit c883a72 into master Jul 16, 2020
@jackofallops jackofallops deleted the b/expressroute-filter-nil-panic branch July 16, 2020 10:19
jackofallops added a commit that referenced this pull request Jul 16, 2020
@ghost
Copy link

ghost commented Jul 16, 2020

This has been released in version 2.19.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.19.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Aug 15, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Aug 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants