-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the compute API to 2017-12-01 / upgrading to Azure SDK v12.4 #797
Update the compute API to 2017-12-01 / upgrading to Azure SDK v12.4 #797
Conversation
- Update the azure-sdk-for-go to v12.4.0-beta since this is the version that introduced 2017-12-01/compute - Change all 2017-03-30/compute import statements to 2017-12-01/compute
hey @justenwalker Thanks for this PR - just to let you know that we'll be looking to get this in as part of v1.1.2, in which we'll upgrade the entire Azure SDK to Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @justenwalker
Thanks for this PR - I've taken a look through and this LGTM 👍
I've run a few VM tests against Azure Public and Azure Germany and this seems to work as expected, as such I'm going to merge this as-is and this will go out as part of v1.1.2.
Thanks!
@tombuildsstuff Thanks! |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
Fixes #799
that introduced 2017-12-01/compute