Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update name validation for azurerm_storage_share_directory #8366

Merged
merged 5 commits into from
Sep 10, 2020

Conversation

neil-yechenwei
Copy link
Contributor

@neil-yechenwei neil-yechenwei commented Sep 7, 2020

fixes #8341
fixes #8168

--- PASS: TestAccAzureRMStorageShareDirectory_basic (210.22s)
--- PASS: TestAccAzureRMStorageShareDirectory_uppercase (211.34s)
--- PASS: TestAccAzureRMStorageShareDirectory_complete (220.86s)
--- PASS: TestAccAzureRMStorageShareDirectory_requiresImport (227.83s)
--- PASS: TestAccAzureRMStorageShareDirectory_update (269.48s)
--- PASS: TestAccAzureRMStorageShareDirectory_nested (317.45s)

…ct leading/trailing dashes, allow double dashes
@ghost ghost added size/M and removed size/XS labels Sep 7, 2020
@manicminer
Copy link
Contributor

@neil-yechenwei Thanks for this update. Hope you don't mind, I've pushed some extra changes to support single character directory names, and ensure each directory component conforms. Also, in my testing, double dashes in filenames seemed to work so I removed that check.

Copy link
Collaborator

@WodansSon WodansSon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@neil-yechenwei Thanks for the PR! It mostly LGTM, however I did leave one very minor comment. Thanks again for the PR 🚀

azurerm/helpers/validate/storage.go Outdated Show resolved Hide resolved
@WodansSon WodansSon added this to the v2.27.0 milestone Sep 8, 2020
@neil-yechenwei neil-yechenwei requested review from WodansSon and removed request for a team September 9, 2020 01:49
@neil-yechenwei
Copy link
Contributor Author

neil-yechenwei commented Sep 10, 2020

@manicminer , thanks for your commit, after tested, but I found the name can start with number and hyphen. So I updated PR by newest name validation rules.
image
image
image
image

@neil-yechenwei
Copy link
Contributor Author

neil-yechenwei commented Sep 10, 2020

@WodansSon , Thanks for your comment. I've updated code according by the newest name validation rules. Please help to have a look. Thanks.

@WodansSon WodansSon dismissed their stale review September 10, 2020 07:41

Changes were made

Copy link
Collaborator

@WodansSon WodansSon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@neil-yechenwei Thanks for pushing those updates, LGTM! 🚀

@WodansSon
Copy link
Collaborator

image

@WodansSon WodansSon merged commit 39612d2 into hashicorp:master Sep 10, 2020
WodansSon added a commit that referenced this pull request Sep 10, 2020
WodansSon added a commit that referenced this pull request Sep 10, 2020
@ghost
Copy link

ghost commented Sep 10, 2020

This has been released in version 2.27.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.27.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Oct 10, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Oct 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants