Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data.azurerm_app_service_environment - Expose vip information of an app service environment #8487

Merged
merged 4 commits into from
Sep 16, 2020
Merged

data.azurerm_app_service_environment - Expose vip information of an app service environment #8487

merged 4 commits into from
Sep 16, 2020

Conversation

favoretti
Copy link
Collaborator

In order to be able to terraform private DNS entries for app_service_environment we need to be able to get to its IP addresses. This patch should expose those properties.

@favoretti favoretti changed the title Expose ip addresses of App Service Environment in datasource Expose IP addresses of App Service Environment in datasource Sep 16, 2020
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mbfrahry mbfrahry changed the title Expose IP addresses of App Service Environment in datasource data.azurerm_app_service_environment - Expose vip information of an App Service Environment Sep 16, 2020
@mbfrahry mbfrahry changed the title data.azurerm_app_service_environment - Expose vip information of an App Service Environment data.azurerm_app_service_environment - Expose vip information of an app service environment Sep 16, 2020
@mbfrahry mbfrahry merged commit 1a1c201 into hashicorp:master Sep 16, 2020
mbfrahry added a commit that referenced this pull request Sep 16, 2020
@mbfrahry mbfrahry added this to the v2.28.0 milestone Sep 16, 2020
@favoretti favoretti deleted the favoretti/app_service_enviroment_ip_addresses branch September 17, 2020 05:51
@ghost
Copy link

ghost commented Sep 17, 2020

This has been released in version 2.28.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.28.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Oct 17, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Oct 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants