Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow azurerm_linux_virtual_machine_scale_set computer_name_prefix to end with dashes #9182

Merged
merged 1 commit into from
Nov 9, 2020
Merged

allow azurerm_linux_virtual_machine_scale_set computer_name_prefix to end with dashes #9182

merged 1 commit into from
Nov 9, 2020

Conversation

bchess
Copy link
Contributor

@bchess bchess commented Nov 5, 2020

Closes #9181

@ghost ghost added the size/XS label Nov 5, 2020
@bchess bchess mentioned this pull request Nov 5, 2020
Closed
tombuildsstuff
tombuildsstuff suggested changes Nov 6, 2020
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @bchess

Thanks for this PR :)

Taking a look through this is looking good, if we can clarify the comment in the validation function (so it handles both use-cases) then this otherwise LGTM 👍

Thanks!

azurerm/internal/services/compute/validation.go Show resolved Hide resolved
@tombuildsstuff tombuildsstuff added this to the v2.36.0 milestone Nov 9, 2020
tombuildsstuff
tombuildsstuff approved these changes Nov 9, 2020
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for pushing those changes @bchess

@tombuildsstuff tombuildsstuff added service/vmss Virtual Machine Scale Sets and removed service/virtual-machine labels Nov 9, 2020
@tombuildsstuff tombuildsstuff merged commit 593e8ae into hashicorp:master Nov 9, 2020
tombuildsstuff added a commit that referenced this pull request Nov 9, 2020
@tombuildsstuff
updating to include #9182 & formatting
fc43a1c
@bchess bchess deleted the linux_name_prefix branch November 9, 2020 18:44
@ghost
Copy link

ghost commented Nov 12, 2020

This has been released in version 2.36.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.36.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Dec 9, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tombuildsstuff tombuildsstuff tombuildsstuff approved these changes

Assignees
No one assigned
Labels
bug service/vmss Virtual Machine Scale Sets size/XS
Projects
None yet
Milestone
v2.36.0
Development

Successfully merging this pull request may close these issues.

azurerm_linux_virtual_machine_scale_set computer_name_prefix should allow ending dashes
2 participants
@bchess @tombuildsstuff