Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_redis_cache - add support for notify-keyspace-events #949

Conversation

bailantaotao
Copy link
Contributor

add new configuration about notify-keyspace-events on Redis

@bailantaotao bailantaotao force-pushed the feature/add-notify-keyspace-events-for-redis-configuration branch from ea2b9df to ab68ea8 Compare March 7, 2018 17:12
@bailantaotao bailantaotao force-pushed the feature/add-notify-keyspace-events-for-redis-configuration branch from ab68ea8 to 86c4b1b Compare March 8, 2018 02:19
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @bailantaotao

Thanks for this PR - I've taken a look through and this LGTM - thanks for this 👍

Thanks!

@tombuildsstuff tombuildsstuff changed the title azurerm: support notify-keyspace-events configuration on Redis azurerm_redis_cache - add support for notify-keyspace-events Mar 8, 2018
@tombuildsstuff tombuildsstuff added this to the 1.3.0 milestone Mar 8, 2018
name = "unlikely23exst2acct%s"
resource_group_name = "${azurerm_resource_group.test.name}"
location = "${azurerm_resource_group.test.location}"
account_type = "Standard_GRS"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in running the tests I noticed this field needs to be split into the two sub-fields - I'll push a commit to fix this :)

account_tier             = "Standard"
account_replication_type = "GRS"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh...thanks for your help :D

@tombuildsstuff
Copy link
Contributor

Tests pass:

screen shot 2018-03-08 at 10 38 32

@tombuildsstuff tombuildsstuff merged commit 60fb353 into hashicorp:master Mar 8, 2018
tombuildsstuff added a commit that referenced this pull request Mar 8, 2018
tombuildsstuff added a commit that referenced this pull request Mar 13, 2018
@ghost
Copy link

ghost commented Mar 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants