Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing required plan information support for Azure Marketplace images in azurerm_virtual_machine_scale_set #95

Closed
hashibot opened this issue Jun 13, 2017 · 5 comments · Fixed by #161
Assignees

Comments

@hashibot
Copy link

This issue was originally opened by @ATLD as hashicorp/terraform#14926. It was migrated here as part of the provider split. The original body of the issue is below.


Terraform Version

Terraform v0.9.6

Affected Resource(s)

  • azurerm_virtual_machine_scale_set

Terraform Configuration Files

...
resource "azurerm_virtual_machine_scale_set" "worker-vmss" {
  name                = "worker-vmss"
  location            = "West Europe"
  resource_group_name = "${azurerm_resource_group.psqldemo-rg.name}"
  upgrade_policy_mode = "Manual"

  plan {
    name = "docker-ce"
    product = "docker-ce"
    publisher = "docker"
  }
...

Expected Behavior

According to virtualMachineScaleSets template reference, for Azure marketplace images, Plan section should be supported in azurerm_virtual_machine_scale_set resource, similarly like for azurerm_virtual_machine resource type.

Actual Behavior

During VMSS creation, in case there is no plan section, Terraform drops the following error:

* azurerm_virtual_machine_scale_set.worker-vmss: 1 error(s) occurred:

* azurerm_virtual_machine_scale_set.worker-vmss: compute.VirtualMachineScaleSetsClient#CreateOrUpdate: Failure sending request: StatusCode=200 -- Original Error: Long running operation terminated with status 'Failed': Code="VMMarketplaceInvalidInput" Message="Creating a virtual machine from Marketplace image requires Plan information in the request. OS disk name is worker-vmss_worker-vmss_0_OsDisk_1_97a2010334f9449baad0f65c9a6351e9."

If I define plan section, I got following error:

1 error(s) occurred:

* azurerm_virtual_machine_scale_set.worker-vmss: : invalid or unknown key: plan
@gaborho
Copy link

gaborho commented Jul 6, 2017

Hi @tombuildsstuff Do you have an estimation when this can be implemented? Currently as a workaround I use ARM template deployment, but this is not ideal, because Terraform does not know about the individual resources created by Azure using a deployment template as mentioned in notes. Thanks.

@tombuildsstuff
Copy link
Contributor

Hey @ATLD

I've put some time aside tomorrow to take a look at this :)

Thanks!

@tombuildsstuff
Copy link
Contributor

Hey @ATLD

Just to let you know that I've opened PR #161 which adds support for setting the Plan on VM Scale Sets :)

Thanks!

@gaborho
Copy link

gaborho commented Jul 10, 2017

Hi @tombuildsstuff , many thanks for your efforts!

@ghost
Copy link

ghost commented Apr 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants