Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource: azurerm_eventgrid_system_topic_event_subscription #9852

Conversation

jrauschenbusch
Copy link
Contributor

@jrauschenbusch jrauschenbusch commented Dec 14, 2020

Solves #9141

$ make acctests SERVICE='eventgrid' TESTARGS='-run=TestAccEventGridSystemTopicEventSubscription' TESTTIMEOUT='60m'               
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./azurerm/internal/services/eventgrid/tests/ -run=TestAccEventGridSystemTopicEventSubscription -timeout 60m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccEventGridSystemTopicEventSubscription_basic
=== PAUSE TestAccEventGridSystemTopicEventSubscription_basic
=== RUN   TestAccEventGridSystemTopicEventSubscription_requiresImport
=== PAUSE TestAccEventGridSystemTopicEventSubscription_requiresImport
=== RUN   TestAccEventGridSystemTopicEventSubscription_eventHubID
=== PAUSE TestAccEventGridSystemTopicEventSubscription_eventHubID
=== RUN   TestAccEventGridSystemTopicEventSubscription_serviceBusQueueID
=== PAUSE TestAccEventGridSystemTopicEventSubscription_serviceBusQueueID
=== RUN   TestAccEventGridSystemTopicEventSubscription_serviceBusTopicID
=== PAUSE TestAccEventGridSystemTopicEventSubscription_serviceBusTopicID
=== RUN   TestAccEventGridSystemTopicEventSubscription_update
=== PAUSE TestAccEventGridSystemTopicEventSubscription_update
=== RUN   TestAccEventGridSystemTopicEventSubscription_filter
=== PAUSE TestAccEventGridSystemTopicEventSubscription_filter
=== RUN   TestAccEventGridSystemTopicEventSubscription_advancedFilter
=== PAUSE TestAccEventGridSystemTopicEventSubscription_advancedFilter
=== CONT  TestAccEventGridSystemTopicEventSubscription_basic
=== CONT  TestAccEventGridSystemTopicEventSubscription_advancedFilter
=== CONT  TestAccEventGridSystemTopicEventSubscription_update
=== CONT  TestAccEventGridSystemTopicEventSubscription_serviceBusQueueID
=== CONT  TestAccEventGridSystemTopicEventSubscription_filter
=== CONT  TestAccEventGridSystemTopicEventSubscription_serviceBusTopicID
=== CONT  TestAccEventGridSystemTopicEventSubscription_eventHubID
=== CONT  TestAccEventGridSystemTopicEventSubscription_requiresImport
--- PASS: TestAccEventGridSystemTopicEventSubscription_basic (162.92s)
--- PASS: TestAccEventGridSystemTopicEventSubscription_filter (163.21s)
--- PASS: TestAccEventGridSystemTopicEventSubscription_advancedFilter (166.75s)
--- PASS: TestAccEventGridSystemTopicEventSubscription_requiresImport (181.75s)
--- PASS: TestAccEventGridSystemTopicEventSubscription_update (210.64s)
--- PASS: TestAccEventGridSystemTopicEventSubscription_serviceBusQueueID (256.79s)
--- PASS: TestAccEventGridSystemTopicEventSubscription_serviceBusTopicID (277.68s)
--- PASS: TestAccEventGridSystemTopicEventSubscription_eventHubID (301.07s)
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/eventgrid/tests     302.469s

Fixes #9141

Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jrauschenbusch! Much of this looks great but I think we should try and consolidate as much as we can since it heavily mirrors EventGrid Event Subscription and if anything changes we'll have issues with ease of maintainability.

Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Just the bit on the .gitignore file and we'll want to add the documentation to the sidebar and we'll be good!

@jrauschenbusch jrauschenbusch force-pushed the eventgrid-system-topic-event-subscription branch from 41ae3ee to a31e64d Compare December 16, 2020 06:34
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mbfrahry mbfrahry changed the title r/azurerm_eventgrid_system_topic_event_subscription New Resource: azurerm_eventgrid_system_topic_event_subscription Dec 16, 2020
@mbfrahry
Copy link
Member

Thanks for this @jrauschenbusch!

@mbfrahry mbfrahry merged commit 82ee2e6 into hashicorp:master Dec 16, 2020
mbfrahry added a commit that referenced this pull request Dec 16, 2020
@mbfrahry mbfrahry added this to the v2.41.0 milestone Dec 16, 2020
@ghost
Copy link

ghost commented Dec 17, 2020

This has been released in version 2.41.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.41.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Jan 16, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Jan 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Event Grid System Topic Subscription
3 participants