Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource/Data Source: azurerm_recovery_services_vault #995

Merged
merged 5 commits into from
Apr 19, 2018

Conversation

katbyte
Copy link
Collaborator

@katbyte katbyte commented Mar 19, 2018

This requires azure SDK for go v14 to be vended in.

@katbyte katbyte added this to the 1.3.1 milestone Mar 19, 2018
@katbyte katbyte removed this from the 1.3.1 milestone Mar 20, 2018
@tombuildsstuff
Copy link
Contributor

Dependent on #1006

@tombuildsstuff
Copy link
Contributor

Fixes #576

@tombuildsstuff
Copy link
Contributor

Tests pass:

$ acctests azurerm TestAccDataSourceAzureRMRecoveryServicesVault_basic
=== RUN   TestAccDataSourceAzureRMRecoveryServicesVault_basic
--- PASS: TestAccDataSourceAzureRMRecoveryServicesVault_basic (75.53s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	75.557s
$ acctests azurerm TestAccAzureRMRecoveryServicesVault_
=== RUN   TestAccAzureRMRecoveryServicesVault_basic
--- PASS: TestAccAzureRMRecoveryServicesVault_basic (74.61s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	74.638s

@tombuildsstuff
Copy link
Contributor

Updated the test check func to make this consistent - and the tests still pass:

$ acctests azurerm TestAccAzureRMRecoveryServicesVault_
=== RUN   TestAccAzureRMRecoveryServicesVault_basic
--- PASS: TestAccAzureRMRecoveryServicesVault_basic (61.24s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	61.266s

and

$ acctests azurerm TestAccDataSourceAzureRMRecoveryServicesVault_basic
=== RUN   TestAccDataSourceAzureRMRecoveryServicesVault_basic
--- PASS: TestAccDataSourceAzureRMRecoveryServicesVault_basic (63.43s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	63.463s

@tombuildsstuff tombuildsstuff changed the title [WIP] Added new resource & data source azurerm_recovery_services_vault New Resource/Data Source: azurerm_recovery_services_vault Apr 19, 2018
@tombuildsstuff tombuildsstuff changed the title New Resource/Data Source: azurerm_recovery_services_vault New Resource/Data Source: azurerm_recovery_services_vault Apr 19, 2018
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff tombuildsstuff merged commit e2b4cf2 into master Apr 19, 2018
@tombuildsstuff tombuildsstuff deleted the f-recovery_service-vault branch April 19, 2018 12:05
@tombuildsstuff tombuildsstuff added this to the 1.4.0 milestone Apr 19, 2018
tombuildsstuff added a commit that referenced this pull request Apr 19, 2018
@PleaseStopAsking
Copy link

Will support for enrolling vm's deployed with the same template be added at a later release as well?

@tombuildsstuff
Copy link
Contributor

@PleaseStopAsking it's on our roadmap at some point but I can't speak to a timeframe unfortunately - would you mind opening a Feature Request for this with more info of what you're after? This would allow others to 👍 the Feature Request so we can prioritise it accordingly :)

@PleaseStopAsking
Copy link

@tombuildsstuff Thanks for the response. I will open Feature Request with further details.

@ghost
Copy link

ghost commented Mar 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants