-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding keyvault service (only standard SKU) with key & secret (soft delete feature not supported) #151
Adding keyvault service (only standard SKU) with key & secret (soft delete feature not supported) #151
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regarding acceptance tests, I think that we have an unexpected behavior when soft delete feature is enabled. Do we assume that, at this moment, soft deletion is not supported ? any opinion @katbyte @tombuildsstuff ? Thank you. |
01c1517
to
565e24b
Compare
@redak-pragma - is this something that is not supported in azure stack at all? or a feature that needs to be enabled on a stack instance? |
@katbyte , not supported at all |
internal/services/keyvault/key_vault_access_policy_data_source.go
Outdated
Show resolved
Hide resolved
internal/services/keyvault/key_vault_access_policy_data_source_test.go
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @redak-pragma - tests pass now so overall this is good to go aside from needed to remove the commented out code. we don't just leave it in. once thats done i'll get this merged!
considering ASH limitations, soft delete is not yet supported
fa05dcc
to
d35ecb2
Compare
@katbyte , thank you for your review, Here my recent changes 60f72bb (will be squashed as soon as you review again this PR, thank you in advance.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @redak-pragma - no need as i'll squash when i merge. LGTM now! 🦀
This PR aims to provide support for KeyVault service only SKU Standard tier.
In some circumstances meaning custom ASH environment, soft deletion should be configurable.
Additionally, sometimes
object_id
is not a valid UUID.