-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to Terraform Plugin Framework #184
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor things, otherwise this is looking great. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
@@ -3,20 +3,30 @@ module github.com/terraform-providers/terraform-provider-external | |||
go 1.18 | |||
|
|||
require ( | |||
github.com/hashicorp/go-cty v1.4.1-0.20200414143053-d3edf31b6320 | |||
github.com/hashicorp/terraform-plugin-docs v0.13.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
drive-by reminder: we should avoid this dependency from upgrading to v0.14.0
as it'll update terraform-exec
to v0.18.0
which will break any acceptance tests that use TestStep > ExpectError
. We can probably just let dependabot handle the upgrade when we release terraform-plugin-docs
v0.14.1
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Closes:
#81
#80
#77
#173