-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
External version 2.3.0 appears to break python packaging in https://github.com/terraform-aws-modules/terraform-aws-lambda #193
Comments
Hi @MerreM, sorry that you are running into this issue. I'm taking a look into this now. |
Thanks! |
As a work-around, pass Edit: given the fix in the related PR, it isn't caused by the switch to the plugin framework. |
FWIW hash_extra = "foo" doesn't appear to work |
Weird, it did for me. Anyway, I preferred to add a provider version constraint to avoid the problematic release. |
Might have implemented it incorrectly. To confirm (for both me and anyone that finds this) - the below should work?
|
Nope, adding the version constraints is done with something like this which is usually put into a terraform {
required_providers {
external = {
version = "< 2.3.0" # https://github.com/hashicorp/terraform-provider-external/issues/193
}
}
} |
I can confirm the issue we are facing using the same module for lambda is resolved with no changes besides the provider update. Thank you! |
|
Wow that was nearly a full day of frustration, eventually just solved by another terraform init! Can also confirm |
Good chance I made a mistake with my pipelines there - I expect your fix would have worked had I managed to call it via CI.
Thank you for the quick fix! |
This is actually still failing as a behavioral change, because it converts |
@lorengordon can you please raise a new issue? Thank you. |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Terraform CLI and Provider Versions
terraform 1.3.7
https://github.com/terraform-aws-modules/terraform-aws-lambda 4.10.1 & 4.7.1
Terraform Configuration
Expected Behavior
Terraform module would run package.py - and produce a zip file for upload
Actual Behavior
-- snip --
Steps to Reproduce
terraform apply
How much impact is this issue causing?
High
Logs
No response
Additional Information
Pipelines failed after
external
provider changed from 2.2.3 to 2.3.0 AFAIK no other changes have occurred.Code of Conduct
The text was updated successfully, but these errors were encountered: