Add support for Pub/Sub topic level message retention configuration

[hedlund]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

This summer Pub/Sub gained the ability to configure message retention on the topic level (as opposed to the subscription level previously supported). This is outlined on the GCP blog and more in depth in the docs.

It would be nice to have this feature added to the appropriate Terraform resource.

New or Affected Resource(s)

• google_pubsub_topic
• data.google_pubsub_topic

Potential Terraform Configuration

# Keeping this very similar looking to the subscription configuration
resource "google_pubsub_topic" "my_topic" {
  message_retention_duration = "21600s"
}

References

• https://cloud.google.com/blog/products/data-analytics/pubsub-gains-topic-retention-feature
• https://cloud.google.com/pubsub/docs/replay-overview#topic_retention

[benjaminfayaz]

Isn't this issue resolved already? https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/pubsub_topic#message_retention_duration

I stumbled across this issue because in the terraform docs the message_retention_duration is described as

Cannot be more than 7 days or less than 10 minutes.

but the cloud console actually says that the maximum is 31 days.
That's probably a whole new issue.

[hedlund]

Isn't this issue resolved already? https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/pubsub_topic#message_retention_duration

Yeah, this was fixed a couple of weeks or so after I opened the issue, but it hasn't been closed..

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.