Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

panic when attempting to apply container_cluster with monitoring_config #10301

Closed
toumorokoshi opened this issue Oct 12, 2021 · 2 comments
Closed
Labels

Comments

@toumorokoshi
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request.
  • Please do not leave +1 or me too comments, they generate extra noise for issue followers and do not help prioritize the request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.
  • If an issue is assigned to the modular-magician user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If an issue is assigned to a user, that user is claiming responsibility for the issue. If an issue is assigned to hashibot, a community member has claimed the issue already.

Terraform Version

$ terraform -v
Terraform v1.0.8
on linux_amd64
+ provider registry.terraform.io/hashicorp/google v3.88.0

Affected Resource(s)

  • google_container_cluster

Terraform Configuration Files

# Copy-paste your Terraform configurations here.
#
# For large Terraform configs, please use a service like Dropbox and share a link to the ZIP file.
# For security, you can also encrypt the files using our GPG public key:
#    https://www.hashicorp.com/security
#
# If reproducing the bug involves modifying the config file (e.g., apply a config,
# change a value, apply the config again, see the bug), then please include both:
# * the version of the config before the change, and
# * the version of the config after the change.

Debug Output

Panic Output

https://gist.github.com/toumorokoshi/519ccbf6ab6446e91befd1dc85a2984e

Expected Behavior

  • create a container cluster

Actual Behavior

  • panic before the API request.

Steps to Reproduce

  1. terraform apply

Important Factoids

Tracking this down a bit, I think it's because monitoring_config is missing the convertStringArr call that exists in logging_config.

I've verified via debugger that Terraform indeed does not cast a []interface to a primitive slice ([]string) when doing the retrieval of the field. So any time you work with an array you need to cast the slice of interfaces to one of strings.

Side note: I'm a little surprised that this test didn't catch the issue. Does magic modules only verify a plan in the snippet above? I've verified that the panic only occurs during apply.

References

@toumorokoshi
Copy link
Author

nvm, looks to be a duplicate of #10280. Will wait for the fix!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant