Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

google_artifact_registry_repository cleanup policy #13824

Comments

@adriantr
Copy link

adriantr commented Feb 23, 2023

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

There is currently no possibility to set cleanup policy for artifact registry through Terraform

New or Affected Resource(s)

  • google_artifact_registry_repository

Potential Terraform Configuration

resource "google_artifact_registry_repository_cleanup_policy" "main" {
  name = "policy"
  action = "DELETE"
  condition {
    version_age = "30d"
  }
}
resource "google_artifact_registry_repository_cleanup_policy_binding" "main" {
  repository = google_artifact_registry_repository.main.name
  project = google_artifact_registry_repository.main.project
  location = google_artifact_registry_repository.main.location
  policy = google_artifact_registry_repository_cleanup_policy.main.id
}

References

  • b/272798258
@rileykarson
Copy link
Collaborator

Note: There's no settings to enable this in the API: https://cloud.google.com/artifact-registry/docs/reference/rest

Not sure how it's available in gcloud, in that case.

@neurolabs
Copy link

https://cloud.google.com/artifact-registry/docs/repositories/cleanup-policy shows how you can use gcloud to set the cleanup policy.

@danquack
Copy link

danquack commented Jun 22, 2023

I'm not seeing the list-functionality return any results, but this is what the CLI is doing

LIST: gcloud artifacts repositories list-cleanup-policies [repository]

GET  https://artifactregistry.googleapis.com/v1/projects/[project-name]/locations/[location]/repositories/[repository]?alt=json
{
  "name": "projects/[project-name]/locations/[location]/repositories/[repository]",
  "format": "DOCKER",
  "createTime": "2023-06-08T01:29:45.938615Z",
  "updateTime": "2023-06-22T14:27:33.401054Z",
  "mode": "STANDARD_REPOSITORY",
  "dockerConfig": {}
}

CREATE: gcloud artifacts repositories set-cleanup-policies [repository] --policy policy.json

PATCH  https://artifactregistry.googleapis.com/v1/projects/[project-name]/locations/[location]/repositories/[repository]?updateMask=cleanupPolicies&alt=json
{
    "cleanupPolicies": {
        "test": {
            "action": "Keep",
            "id": "test",
            "mostRecentVersions": {
                "keepCount": 100000
            }
        }
    },
    "createTime": "2023-06-08T01:29:45.938615Z",
    "dockerConfig": {},
    "format": "DOCKER",
    "mode": "STANDARD_REPOSITORY",
    "name": "projects/[project-name]/locations/[location]/repositories/[repository]",
    "updateTime": "2023-06-22T14:14:01.780517Z"
}

DELETE gcloud artifacts repositories delete-cleanup-policies [repository] --policy policy.json

PATCH  https://artifactregistry.googleapis.com/v1/projects/[project-name]/locations/[location]/repositories/[repository]?updateMask=cleanupPolicies&alt=json
{
    "createTime": "2023-06-08T01:29:45.938615Z",
    "dockerConfig": {},
    "format": "DOCKER",
    "mode": "STANDARD_REPOSITORY",
    "name": "projects/[project-name]/locations/[location]/repositories/[repository]",
    "updateTime": "2023-06-22T14:27:33.401054Z"
}

@nathadfield
Copy link

Artifact Registry cleanup policies were officially released into preview last week. https://cloud.google.com/artifact-registry/docs/release-notes

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.