Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Media CDN EdgeCacheService resources enforce query parameter limits smaller than the Google API #15113

Assignees

Comments

@justin-mp
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request.
  • Please do not leave +1 or me too comments, they generate extra noise for issue followers and do not help prioritize the request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.
  • If an issue is assigned to the modular-magician user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If an issue is assigned to a user, that user is claiming responsibility for the issue. If an issue is assigned to hashibot, a community member has claimed the issue already.

Terraform Version

Google Provider: v4.72.0

Affected Resource(s)

  • google_resource_network_services_edge_cache_service.go

Terraform Configuration Files

In google_resource_network_services_edge_cache_service.go, the provider has the following MaxItems limits:

"included_query_parameters": {
	Type:     schema.TypeList,
	Optional: true,
	MaxItems: 10,
	Elem: &schema.Schema{
		Type: schema.TypeString,
	},
},

"excluded_query_parameters": {
	Type:     schema.TypeList,
	Optional: true,
	MaxItems: 10,
	Elem: &schema.Schema{
		Type: schema.TypeString,
  },
},

Debug Output

N/A

Panic Output

N/A

Expected Behavior

Google Media CDN has higher limits for these items and Terraform should not artificially restrict the limits.

According to https://cloud.google.com/media-cdn/docs/reference/rest/v1/projects.locations.edgeCacheServices#cachekeypolicy, customers may set up to 20 includedQueryParameters and 20 excludedQueryParameters.

Actual Behavior

Terraform limts the MaxItems allowed.

Steps to Reproduce

Add more than the allowed number of items and then run terraform apply.

Important Factoids

References

@justin-mp justin-mp added the bug label Jul 10, 2023
@edwardmedia edwardmedia self-assigned this Jul 10, 2023
@edwardmedia
Copy link
Contributor

Looks like the api keeps expanding on these values
#14163

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.