Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip delete operation for bare metal admin cluster resource #15766

Closed
naitianliu-google opened this issue Sep 7, 2023 · 2 comments
Closed

Skip delete operation for bare metal admin cluster resource #15766

naitianliu-google opened this issue Sep 7, 2023 · 2 comments

Comments

@naitianliu-google
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

Currently the delete operation maps to the unenroll API because we do not have the delete API method to clean up the admin cluster resource and all its dependencies. However, customers may feel confused after running terraform destroy but the admin cluster resource is not actually deleted. After the internal discussion, we decide to map the delete operation to no-op in TF and guide users to manually delete admin cluster resource in the doc.

Here is the bug for more context. b/298059927

GoogleCloudPlatform/magic-modules#8823

Please note this is a breaking change and need to be tracked in 5.0.0 release.

New or Affected Resource(s)

  • google_gkeonprem_bare_metal_admin_cluster

Potential Terraform Configuration

# Propose what you think the configuration to take advantage of this feature should look like.
# We may not use it verbatim, but it's helpful in understanding your intent.

References

  • #0000
@c2thorn
Copy link
Collaborator

c2thorn commented Sep 26, 2023

closed with GoogleCloudPlatform/magic-modules#8823

@c2thorn c2thorn closed this as completed Sep 26, 2023
@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants