Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use network_config over network in google_alloydb_cluster examples #16848

Closed
rileykarson opened this issue Dec 20, 2023 · 3 comments
Closed

Use network_config over network in google_alloydb_cluster examples #16848

rileykarson opened this issue Dec 20, 2023 · 3 comments

Comments

@rileykarson
Copy link
Collaborator

rileykarson commented Dec 20, 2023

Current examples all use network, we should use the non-deprecated variant in all of them (or all but one if we want an example of the old mechanism to stick around). Related to #16119, the removal in 6.0.0.

We shouldn't eliminate usages entirely, and should keep some in handwritten tests.

b/319230983

@c2thorn
Copy link
Collaborator

c2thorn commented Jul 29, 2024

Note that this is heavily related to #16119 and should be done simultaneously

@c2thorn
Copy link
Collaborator

c2thorn commented Aug 8, 2024

closing as duplicate of #16119

@c2thorn c2thorn closed this as completed Aug 8, 2024
Copy link

github-actions bot commented Sep 9, 2024

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants