Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add disk labels to google_compute_instance_template #2026

Closed
ahill00 opened this issue Sep 11, 2018 · 3 comments
Closed

Add disk labels to google_compute_instance_template #2026

ahill00 opened this issue Sep 11, 2018 · 3 comments

Comments

@ahill00
Copy link

ahill00 commented Sep 11, 2018

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Terraform Version

Terraform v0.11.7
provider.google v1.17.1

Description

Requesting that google_compute_instance_template gets supports for disk labels. Support is present in the Compute API already.

New or Affected Resource(s)

  • google_compute_instance_template

Potential Terraform Configuration

https://www.terraform.io/docs/providers/google/r/compute_instance_template.html

# Propose what you think the configuration to take advantage of this feature should look like.
# We may not use it verbatim, but it's helpful in understanding your intent.
resource "google_compute_instance_template" "foo" {
  name_prefix        = "foo"
  ###....
  disk { 
  	boot = true
  	auto_delete = true
  	labels = {
	    cost-center = "marketing",
	    env = "production"
	}
  }
###...
}

References

@marcboudreau
Copy link

I've created a PR (#3766) to address this issue.

@chrisst
Copy link
Contributor

chrisst commented Dec 11, 2019

fixed by #3766

@chrisst chrisst closed this as completed Dec 11, 2019
@ghost
Copy link

ghost commented Mar 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants