Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mismatch between docs and stable provider around CloudSQL private instances #2937

Closed
slavaaaaaaaaaa opened this issue Jan 25, 2019 · 3 comments
Labels

Comments

@slavaaaaaaaaaa
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment
  • If an issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If an issue is assigned to a user, that user is claiming responsibility for the issue. If an issue is assigned to "hashibot", a community member has claimed the issue already.

Terraform Version

$ terraform version
Terraform v0.11.11
+ provider.google v1.19.1

Affected Resource(s)

  • google_sql_database_instance

Terraform Configuration Files

resource "google_sql_database_instance" "master" {
  name = "${var.name}"
  database_version = "POSTGRES_9_6"
  region = "${var.region}"

  settings {
    tier = "${var.tier}"
    disk_size = "${var.disk_size}"
    disk_autoresize = true

    database_flags {
      name = "temp_file_limit"
      value = "2147483647"
    }

    ip_configuration {
      require_ssl = true
      private_network = "${var.private_network_self_link}"
    }
  }
}

Debug Output

Error: module.cloudsql.google_sql_database_instance.master: settings.0.ip_configuration.0: invalid or unknown key: private_network

Panic Output

Expected Behavior

According to docs, this is valid syntax. It's expected that the CloudSQL instance comes up with a private IP.

Actual Behavior

Terraform does not validate the code.

Steps to Reproduce

  1. terraform apply

Important Factoids

According to #2127 , it seems the provider won't actually support this until v2.0.0. Since the docs are present, however, one would expect support to be present in a stable version as well.

References

@ghost ghost added the bug label Jan 25, 2019
@rileykarson
Copy link
Collaborator

It looks like you're on 1.19.1, and the feature was added in 1.20.0; https://github.com/terraform-providers/terraform-provider-google/blob/master/CHANGELOG.md#1200-december-14-2018

Sorry for the confusion around versions- we expected at the time that 2.0.0 would be the next release, but ended up making release 1.20.0. If this doesn't work after upgrading, feel free to comment on this issue and we'll reopen it.

@slavaaaaaaaaaa
Copy link
Author

@rileykarson Ah, thank you, that makes a whole lot of sense. Things are working now, and I don't have to build the provider to use it.

Cheers!

@ghost
Copy link

ghost commented Feb 25, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Feb 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants