Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Random failure of creating storage bucket acl #2939

Closed
jclarksnps opened this issue Jan 25, 2019 · 4 comments
Closed

Random failure of creating storage bucket acl #2939

jclarksnps opened this issue Jan 25, 2019 · 4 comments
Assignees

Comments

@jclarksnps
Copy link

jclarksnps commented Jan 25, 2019

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment
  • If an issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If an issue is assigned to a user, that user is claiming responsibility for the issue. If an issue is assigned to "hashibot", a community member has claimed the issue already.

Terraform Version

0.11.10

Affected Resource(s)

google_storage_bucket_acl

Terraform Configuration Files

resource "google_service_account" "service_account" {
  account_id    = "store-${var.environment}-rw"
  display_name  = "store-${var.environment} rw account"
}

resource "google_storage_bucket_acl" "acl_master" {
  depends_on = ["google_service_account.service_account"]
  bucket = "store-master"
  role_entity = [
    "READER:user-${google_service_account.service_account.email}"
  ]
}

Debug Output

  • google_storage_bucket_acl.acl_master: 1 error(s) occurred:

  • google_storage_bucket_acl.acl_master: Error updating ACL for bucket store-master: googleapi: Error 400: Unknown user email address: [email protected], invalid

Panic Output

Expected Behavior

The resource should be created everytime.

Actual Behavior

It randomly fails, note that the account that it says doesn't exist was indeed created.

google_service_account.service_account: Creation complete after 1s

Steps to Reproduce

  1. terraform apply multiple times sometimes it will fail.

Important Factoids

References

  • #0000
@ghost ghost added the bug label Jan 25, 2019
@rileykarson rileykarson self-assigned this Feb 15, 2019
@rileykarson
Copy link
Collaborator

I think this is an eventual consistency issue that we can't really do anything about in the provider. If you wait a minute and try again does it apply correctly?

@jclarksnps
Copy link
Author

That was effectively our fix, sleep for 45s before doing anything else. Not a great pattern to do, but only choice right now.

@rileykarson
Copy link
Collaborator

Since this is an API issue and isn't something I can believe we can fix in the provider in a satisfying way, I'll add some documentation to the resource indicating the issue to close this out.

@ghost
Copy link

ghost commented Mar 22, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants