Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support adding/removing Bigtable clusters #4318

Closed
garye opened this issue Aug 22, 2019 · 8 comments · Fixed by GoogleCloudPlatform/magic-modules#2923
Closed

Support adding/removing Bigtable clusters #4318

garye opened this issue Aug 22, 2019 · 8 comments · Fixed by GoogleCloudPlatform/magic-modules#2923

Comments

@garye
Copy link

garye commented Aug 22, 2019

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

In addition to resizing existing clusters, some customers would like the ability to add or remove clusters in an instance.

@garye
Copy link
Author

garye commented Aug 23, 2019

@rileykarson I have a version of this in the Bigtable client coded up, but what do you think about pushing it to the terraform layer instead?

@rileykarson
Copy link
Collaborator

Yeah, we could implement it Terraform-side. Holistically I'm slightly in preference of having it live in the client lib, since then other clients can use the same functionality, but if you're hesitant to expose it there it can live here.

@garye
Copy link
Author

garye commented Aug 23, 2019

I don't really have a problem exposing it in the library, I'll add you to the CL and see what the Go client reviewers have to say.

@garye
Copy link
Author

garye commented Aug 25, 2019

There's some mild pushback against putting this new method in the library, so I'd like to try and find a home for it in this project if possible.

Is the right approach to put a utility method for syncing clusters in https://github.com/terraform-providers/terraform-provider-google/blob/master/google/resource_bigtable_instance.go?

@rileykarson
Copy link
Collaborator

Sure!

@rileykarson
Copy link
Collaborator

@stankiewicz, let me know if you made any more progress on this that didn't end up on GH. I'll pick this up in a couple weeks if not, and get it in for whatever release happens next after that, somewhere between 3.3.0 and 3.5.0.

@rileykarson
Copy link
Collaborator

This will be supported in 3.5.0+.

@ghost
Copy link

ghost commented Feb 7, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Feb 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants