Remove long form name behavior for pubsub subscriptions

[paddycarver]

I'm not sure on the background of this one, but it came up in our discussion of 3.0.0 goals. I believe you can currently specify two versions of the pubsub subscription name, and the long one is undesirable for some reason, and so we want to stop supporting it. @danawillow, assigning this to you so you can assign it to Cameron when they get commit access.

[rileykarson]

I forget the exact context, but we have custom code to allow specifying something- I think the name- as either the shortname or long name. We kept it for BC reasons when MM-ifying the resource, but we can remove some of that behaviour (and the underlying custom code) in 3.0.0.

Edit: Actually, I think the field was topic. See hashicorp/terraform-provider-google-beta#432 (comment)

[danawillow]

topic is currently doing compareSelfLinkOrResourceName which seems perfectly reasonable for it to do. name is comparePubsubSubscriptionBasename which seems like the actual one to get rid of (and instead treat it like the other newer-style APIs where the name field is always short). Does that sound like what you were thinking, @rileykarson?

[rileykarson]

Ah- yep, I think that was it.

[danawillow]

Cool. Since @c2thorn has plenty of other things on his plate right now, I'm going to go ahead and take this since it's pretty quick.

[rileykarson]

Closed in linked issue ("Fixes: " doesn't work in non-primary branches)

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!