Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enabled-logging feature in google_compute_firewall needs to be added in GA #4836

Closed
sanmmishra opened this issue Nov 7, 2019 · 2 comments
Closed

Comments

@sanmmishra
Copy link

sanmmishra commented Nov 7, 2019

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

As per this announcement, the enable logging (which enables firewall level logs) is in GA, but the google provider (GA) doesnt support it yet (see line 113/ 128) . It is only supported by beta

https://github.com/terraform-google-modules/terraform-google-network/blob/master/modules/fabric-net-firewall/main.tf

Can we add this feature to the GA provider?

New or Affected Resource(s)

  • google_compute_firewall"

Potential Terraform Configuration

resource "google_compute_firewall" "custom" {
  name                    = foofw
  description             = foodescription
  direction               = INGRESS
  network                 = default
  project                 = foo-project
  enable_logging          = true
}
  • #0000
@venkykuberan
Copy link
Contributor

@sanmmishra enable-logging feature is added to GA here. Hence i am closing this ticket

@ghost
Copy link

ghost commented Mar 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants